-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger-db restructuring #3441
ledger-db restructuring #3441
Conversation
Ben-PH
commented
Jan 18, 2023
•
edited
Loading
edited
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
I've been looking into making the results of the getters return a byte-slice instead of a vec as well. The issue is that the library uses the How to make the v-table containing the drop method available outside of |
d1d027e
to
8db0a92
Compare
We usually employ "refactor" when dealing with major behavioral changes of a module, I changed the title to restructuring to avoid misleading anyone. Also I'm not a big fan of the |
I'll revert file separation, then merge on monday. I'll also raise a discussion in github about that (I personally prefer not to have |
2184d8e
to
fdb4310
Compare