Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(harper-ls): change filename to -msvc from -gnu #7536

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elijah-potter
Copy link
Contributor

Describe your changes

We've added some additional language support and changed our target compiler architecture. This PR fixes the broken filename and highlights this language support.

@williambotman williambotman requested a review from a team October 13, 2024 16:04
@elijah-potter
Copy link
Contributor Author

@williamboman is there anything I need to do to get this merged? I've got users who need this as soon as possible.

@elijah-potter
Copy link
Contributor Author

Just wanted to nudge again to see if there's anything I can do to get this merged @williamboman or @chrisgrieser

@chrisgrieser
Copy link
Contributor

chrisgrieser commented Nov 23, 2024

@elijah-potter Looks good to me, I've been using this package spec in my personal config (manually added) already: https://github.com/chrisgrieser/.config/blob/main/nvim/personal-mason-registry/packages/harper-ls/package.yaml

I think this PR not being merged isn't due to the changes, but simply due to the maintainer not being available. There are 150+ open PRs, after all. Unfortunately, I am just an occasional contributor and do not have the rights to merge anything in this repo; otherwise, I'd have done so already. (I also have a few open PRs for this repo waiting to be merged.)

@elijah-potter
Copy link
Contributor Author

@chrisgrieser is see. That makes sense. Hopefully he sees this soon 🤞. We've got a lot of improvements that I can't push out yet because of this.

@chrisgrieser
Copy link
Contributor

We've got a lot of improvements that I can't push out yet because of this.

@elijah-potter If this is about a new release, then you can still go for it. People can still install harper-ls manually or via a personal mason registry (like I do). As I harper-user I am looking forward to some improvements myself 😋

@DYnamoX513
Copy link

Any update on this? Why doesn't the Renovate bot pick up the update from harper-ls? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants