Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for package #60

Closed
lh0x00 opened this issue Feb 21, 2019 · 4 comments
Closed

Refactor for package #60

lh0x00 opened this issue Feb 21, 2019 · 4 comments

Comments

@lh0x00
Copy link
Contributor

lh0x00 commented Feb 21, 2019

hi @maslianok
Long time no see, I have maintained and contributed to some projects, so far I think it is time we need a major update on the performance and problems of this library. Can I refactor new version for lib using ref of React to wrap component instead of adding a new element and improve performance for lib? Maybe this is a big update for lib!
@maslianok
Copy link
Owner

hey @lamhieu-vk
Glad to see you again :)

Yes, sure! It would be very helpful!

@lh0x00
Copy link
Contributor Author

lh0x00 commented Feb 21, 2019

@maslianok thank you, I make a PR soon!

@lh0x00 lh0x00 mentioned this issue Feb 27, 2019
Merged
9 tasks
@maslianok
Copy link
Owner

Big thanks @lamhieu-vk for leading this refactoring!
Awesome suggestions and awesome quality of code! Thanks!

@lh0x00
Copy link
Contributor Author

lh0x00 commented Mar 4, 2019

@maslianok I really happy when read your comment, nice to be the maintainer of the project in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maslianok @lh0x00