#86 (comment): added extra constraint (#92)

src/net/KEFCore.SerDes/IValueContainer.cs

@@ -20,15 +20,15 @@
 
 namespace MASES.EntityFrameworkCore.KNet.Serialization;
 /// <summary>
-/// This is the main interface a class must implmenet to be a ValueContainer. More info <see href="https://masesgroup.github.io/KEFCore/articles/serialization.html">here</see>
+/// This is the main interface a class must implement to be a ValueContainer. More info <see href="https://masesgroup.github.io/KEFCore/articles/serialization.html">here</see>
 /// </summary>
 /// <typeparam name="T">It is the key <see cref="Type"/> passed from Entity Framework associated to the Entity data will be stored in the ValueContainer</typeparam>
 public interface IValueContainer<in T> where T : notnull
 {
     /// <summary>
     /// Returns back the raw data associated to the Entity
     /// </summary>
-    /// <param name="tName">The <see cref="IEntityType"/> requesting to get the data back</param>
+    /// <param name="tName">The requesting <see cref="IEntityType"/> to get the data back</param>
     /// <param name="array">The array of object to be filled in with the data stored in the ValueContainer</param>
     void GetData(IEntityType tName, ref object[] array);
 }

src/net/KEFCore/Storage/Internal/EntityTypeProducer.cs

@@ -38,8 +38,8 @@ namespace MASES.EntityFrameworkCore.KNet.Storage.Internal;
 public class EntityTypeProducer<TKey, TValueContainer, TKeySerializer, TValueSerializer> : IEntityTypeProducer
     where TKey : notnull
     where TValueContainer : class, IValueContainer<TKey>
-    where TKeySerializer : class
-    where TValueSerializer : class
+    where TKeySerializer : class, new()
+    where TValueSerializer : class, new()
 {
     private readonly ConstructorInfo TValueContainerConstructor;
     private readonly bool _useCompactedReplicator;
@@ -192,8 +192,8 @@ public EntityTypeProducer(IEntityType entityType, IKafkaCluster cluster)
         var tTValueContainer = typeof(TValueContainer);
         TValueContainerConstructor = tTValueContainer.GetConstructors().Single(ci => ci.GetParameters().Length == 2);
 
-        _keySerdes = Activator.CreateInstance(typeof(TKeySerializer)) as IKNetSerDes<TKey>;
-        _valueSerdes = Activator.CreateInstance(typeof(TValueSerializer)) as IKNetSerDes<TValueContainer>;
+        _keySerdes = new TKeySerializer() as IKNetSerDes<TKey>;
+        _valueSerdes = new TValueSerializer() as IKNetSerDes<TValueContainer>;
 
         if (_useCompactedReplicator)
         {

src/net/KEFCore/Storage/Internal/EntityTypeProducers.cs

@@ -36,8 +36,8 @@ public class EntityTypeProducers
     public static IEntityTypeProducer Create<TKey, TValueContainer, TKeySerializer, TValueSerializer>(IEntityType entityType, IKafkaCluster cluster)
         where TKey : notnull
         where TValueContainer : class, IValueContainer<TKey>
-        where TKeySerializer : class
-        where TValueSerializer : class
+        where TKeySerializer : class, new()
+        where TValueSerializer : class, new()
     {
         return _producers.GetOrAdd(entityType, _ => CreateProducerLocal<TKey, TValueContainer, TKeySerializer, TValueSerializer>(entityType, cluster));
     }
@@ -54,7 +54,7 @@ public static void Dispose(IEntityTypeProducer producer)
     static IEntityTypeProducer CreateProducerLocal<TKey, TValueContainer, TKeySerializer, TValueSerializer>(IEntityType entityType, IKafkaCluster cluster)
         where TKey : notnull
         where TValueContainer : class, IValueContainer<TKey>
-        where TKeySerializer : class
-        where TValueSerializer : class
+        where TKeySerializer : class, new()
+        where TValueSerializer : class, new()
         => new EntityTypeProducer<TKey, TValueContainer, TKeySerializer, TValueSerializer>(entityType, cluster);
 }

src/net/KEFCore/Storage/Internal/KafkaTable.cs

@@ -36,8 +36,8 @@ namespace MASES.EntityFrameworkCore.KNet.Storage.Internal;
 public class KafkaTable<TKey, TValueContainer, TKeySerializer, TValueSerializer> : IKafkaTable
     where TKey : notnull
     where TValueContainer : class, IValueContainer<TKey>
-    where TKeySerializer : class
-    where TValueSerializer : class
+    where TKeySerializer : class, new()
+    where TValueSerializer : class, new()
 {
     private readonly IPrincipalKeyValueFactory<TKey> _keyValueFactory;
     private readonly bool _sensitiveLoggingEnabled;

src/net/KEFCore/Storage/Internal/KafkaTableFactory.cs

@@ -65,7 +65,7 @@ private static Func<IKafkaTable> CreateFactory<TKey, TValueContainer, TKeySerial
         bool sensitiveLoggingEnabled)
         where TKey : notnull
         where TValueContainer : class, IValueContainer<TKey>
-        where TKeySerializer : class
-        where TValueSerializer : class
+        where TKeySerializer : class, new()
+        where TValueSerializer : class, new()
         => () => new KafkaTable<TKey, TValueContainer, TKeySerializer, TValueSerializer>(cluster, entityType, sensitiveLoggingEnabled);
 }