Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push will have problems #12

Open
gaohomway opened this issue Apr 18, 2019 · 7 comments
Open

Push will have problems #12

gaohomway opened this issue Apr 18, 2019 · 7 comments

Comments

@gaohomway
Copy link

Push will have problems, Have you noticed? It should be a problem with the agent.

1555568203724

@masamichiueta
Copy link
Owner

What do you mean? Can you attach a gif?

@gaohomway
Copy link
Author

Recorded a video that you can download and watch.

@masamichiueta
Copy link
Owner

Ah, I understand. Thanks, I will check it.

@gaohomway
Copy link
Author

@masamichiueta Thank you very much for sharing this library.

But I am very difficult to use, especially when it comes to integration.
The photo transition should be a public library, but your business logic for this intrusion.
I think it is a structural problem, I think the structure should be:

Grid:【UICollectionView】-【UICollectionViewCell】-【UIImageView】-【Click event】->
Browse:【UICollectionView】-【UICollectionViewCell】-【UIScrollView】-【UIImageView】

This is the structure I think is ideal.
UICollectionView instead of UIPageViewController and UIViewController. what do you think?

@masamichiueta
Copy link
Owner

@weifans Thanks for your feedback!
Yes, I'm also considering that using UICollectionView may be better.

I will refactor this project later.

@gaohomway
Copy link
Author

@masamichiueta I haven't seen you for a long time. I have been busy recently. Is there an upgrade plan?

@masamichiueta
Copy link
Owner

@weifans Sorry, I'm working another project now, and refactoring priority is low now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants