Skip to content
This repository has been archived by the owner on May 5, 2024. It is now read-only.

Move to node 16 #543

Closed
ldeluigi opened this issue Oct 11, 2022 · 13 comments · Fixed by #546
Closed

Move to node 16 #543

ldeluigi opened this issue Oct 11, 2022 · 13 comments · Fixed by #546

Comments

@ldeluigi
Copy link
Contributor

Currently some actions are still using node 12 instead of node 16, which raises warnings and errors

@maggie44
Copy link
Contributor

This is untested, can you see if this fixes the issue? #546

@SimonLammer
Copy link

This is the concrete warning annotation shown in the workflow summary (when using @latest):

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: marvinpinto/action-automatic-releases

@glensc
Copy link

glensc commented Dec 12, 2022

There are no errors. just warnings

@james-crocker
Copy link

Correct; no errors at the moment. But per link documentation GitHub support for Node12 is deprecated and may easily become an 'error' condition sometime in the Summer of 2023.

@Vadorequest
Copy link

I am encountering a similar issue, my GH action relies on this action, I'm getting the warning regarding node16 as well.

It would be best to address this ASAP. Here are the things I had to do for my actions:

@Vadorequest
Copy link

Vadorequest commented Jan 9, 2023

A PR has been made at #546 6 days ago, but hasn't been reviewed/merged by the author yet.

Someone else mentioned https://github.com/softprops/action-gh-release, which seems actively maintained.

I decided to switch to softprops/action-gh-release, here is my PR for migration details:
UnlyEd/github-action-await-vercel#86

@dimaqq
Copy link

dimaqq commented Mar 1, 2023

@marvinpinto 🙏🏻

@bdlake
Copy link

bdlake commented Mar 6, 2023

+1

@whanata
Copy link

whanata commented Apr 4, 2023

+1

@jensenbox
Copy link

Any movement on this?

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: marvinpinto/action-inject-ssm-secrets@latest. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

It is only annoying and definitely not life-threatening.

@SimonDarksideJ
Copy link

It is only annoying and definitely not life-threatening.

Actually, GitHub are deprecating actions using older Node versions (along with set-output) and they will cease to function after that.

@HiranChaudhuri
Copy link

Whatever may be going on in the background: As long as these changes are not released they are not usable by other workflows.
Hence I am wondering why all these issues get closed.

@sbe-arg
Copy link
Collaborator

sbe-arg commented Jun 16, 2023

We are rebumping this project a bit mainly the releases part stay tunned

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.