Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending PASS to password protected irc server prepends : #87

Closed
petecheslock opened this issue May 10, 2012 · 0 comments
Closed

Sending PASS to password protected irc server prepends : #87

petecheslock opened this issue May 10, 2012 · 0 comments

Comments

@petecheslock
Copy link

Seeing an issue using node-irc with a password protected IRC server.

When sending the PASS in this section:
https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L510

It prepends : to the password (and thus the password fails)

It looks like from this line:
https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L603

Here is what we saw when we enabled extra logging on our IRC server:
INFO | server.commands | #<NioAcceptedSocketChannel [id: 0x00b15b0c, /10.9.1.11:45366 => /10.194.154.5:6667]> sent PASS-> :blah
INFO | server.commands | #<NioAcceptedSocketChannel [id: 0x01b3358f, /10.9.1.11:45467 => /10.194.154.5:6667]> sent PASS-> :blah
INFO | server.commands | #<NioAcceptedSocketChannel [id: 0x00165861, /10.1.1.17:37850 => /10.194.154.5:6667]> sent PASS-> blah

The first 2 lines were using node-irc - the last one used a generic IRC client.

Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants