Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel letter-case crashes client #39

Closed
awwright opened this issue Oct 22, 2011 · 3 comments
Closed

Channel letter-case crashes client #39

awwright opened this issue Oct 22, 2011 · 3 comments

Comments

@awwright
Copy link

Commit 549d62f introduced a bug where channels with uppercase letters will crash the client because the channel name is, for example, #Node.js as returned by Freenode, but stored as #node.js. While JOIN, PART, and KICK operations don't trigger a crash, any other command that looksup the channel by name does, like in this case a channel mode:

node_modules/irc/lib/irc.js:913
                     throw err;
                           ^
TypeError: Cannot read property 'users' of undefined
     at Client.<anonymous> (node_modules/irc/lib/irc.js:611:40)
     at Client.emit (events.js:88:20)
     at node_modules/irc/lib/irc.js:910:22
     at Array.forEach (native)
     at Socket.<anonymous> (node_modules/irc/lib/irc.js:907:15)
     at Socket.emit (events.js:67:17)
     at TCP.onread (net.js:302:31)

Reverting the above commit fixes any crashing (which I don't fully understand, since it says it was supposed to fix such crashes).

The client should assume that the particular case the IRC server uses is meaningful, so if it changes the case on us we should adopt that case instead.

@fent
Copy link
Contributor

fent commented Oct 27, 2011

+1

I was about to open an issue on this myself. :)

@martynsmith
Copy link
Owner

Okay, I believe that in commit cb165a4 I've fixed this issue, can you please re-open this if it's not working for you now?

@awwright
Copy link
Author

This has been working with no problems, thanks!

Half-Shot referenced this issue in matrix-org/node-irc Feb 23, 2019
….0.0

[Doppins] Upgrade dependency sinon to ^4.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants