-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Automatic flood protection #36
Comments
Hmmm, that sounds interesting. Do you have time to throw together a patch that demonstrates this? Otherwise feel free to leave this open, and I'll have an investigation of it when I get time :-) |
Well, I'm not really sure if it's a good idea in the first place. Flood protection seems to be more for preventing server kicks; bufferSize is more for not saturating the bandwidth of the user. |
Okay, and it seems to me that if you're trying to limit bandwidth, that's really outside the scope of this module. Do you want to close this issue then? |
[Doppins] Upgrade dependency nyc to 11.2.1
Instead of queuing commands to be sent, monitor conn.bufferSize and automatically enable flood protection based on that. (Possibly using conn.pause() and conn.resume() instead of queuing commands.)
See node/.../doc/api/net.markdown
The text was updated successfully, but these errors were encountered: