-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document 'selfMessage' from #17 #349
Comments
I just noticed that emit('selfMessage') has been moved to _speak, but it still might be better in prototype.send. I think the purpose of selfMessage is to give an event that lets irc consumers debug outbound messages. |
The docs have been updated with |
I pushed a PR to change this: #353 |
Thanks for the quick update. What do you think about an event like 'sendAll' that could be used to tap into all outgoing messages? e.g. Modes, joins, parts... The following probably deserves another issue, but thought I'd ask here first. In defense of this point, when the debug option is set, Changing selfMessage to sendMessage would be a breaking change, unless .on & .addListener were wrapped to replace selfMessage with sendMessage and give a deprecation warning 'use sendMessage instead of selfMessage'. Then in a later release remove the wrapper. Just thinking out loud. Thanks again for documentation |
@jhr007 I like it. I'll make a new issue for standardizing events and debug logs for everything the client sends. |
I just found #17 and noticed adding emit(selfMessage) was not in the documentation.
Also... Semantically, I think this event would be a better service if it was moved to client.send ....
Thoughts?
The text was updated successfully, but these errors were encountered: