Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass channel MODE with -lk throws error #177

Closed
metaglot opened this issue Jul 22, 2013 · 2 comments
Closed

Mass channel MODE with -lk throws error #177

metaglot opened this issue Jul 22, 2013 · 2 comments

Comments

@metaglot
Copy link

I get this when my client is in a channel and someone sets mode -lk

(It might be worth noting that i have changed my irc.js to use Array.splice instead of delete as in Fix deletion of array elements.)

/usr/share/adafruit/webide/node_modules/irc/lib/irc.js:638
throw err;
^
TypeError: Cannot read property 'length' of undefined
at /usr/share/adafruit/webide/node_modules/irc/lib/irc.js:248:41
at Array.forEach (native)
at Client. (/usr/share/adafruit/webide/node_modules/irc/lib/irc.js:226:26)
at Client.EventEmitter.emit (events.js:117:20)
at /usr/share/adafruit/webide/node_modules/irc/lib/irc.js:635:22
at Array.forEach (native)
at Socket. (/usr/share/adafruit/webide/node_modules/irc/lib/irc.js:632:15)
at Socket.EventEmitter.emit (events.js:95:17)
at Socket. (_stream_readable.js:736:14)
at Socket.EventEmitter.emit (events.js:92:17)

@metaglot
Copy link
Author

I am sorry, subtract 1 from all source line numbers

@ward
Copy link

ward commented Mar 27, 2016

This was fixed by PR #351, I confirmed locally that 0.4.1 still has the bug while 0.5.0 does not any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants