Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpl_channelmodeis messages are not parsed correctly #120

Closed
Philipp15b opened this issue Nov 3, 2012 · 3 comments
Closed

rpl_channelmodeis messages are not parsed correctly #120

Philipp15b opened this issue Nov 3, 2012 · 3 comments

Comments

@Philipp15b
Copy link

When connecting to irc.freenode.net#ubuntu irc.js encounters an TypeError because message in line 877 is null. The command was rpl_channelmodeis.

The contents of line are:

botname #ubuntu +CLcntjf 5:10 #ubuntu-unregged
@cmcculloh
Copy link

I've got a fix for this one. Just need to isolate the change and issue a pull request...

@quentinxs
Copy link
Contributor

Fixed in #137 and a test for such a line has been added to the library.

@martynsmith
Copy link
Owner

I'm fairly sure @qsheets is correct, this is fixed in #137. If however you still have issues, check out the test I just added and file a pull request with an amended test.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cmcculloh @martynsmith @Philipp15b @quentinxs