Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecastie in Dashclock: Settings do not open #190

Closed
davidhedlund opened this issue May 17, 2017 · 9 comments
Closed

Forecastie in Dashclock: Settings do not open #190

davidhedlund opened this issue May 17, 2017 · 9 comments

Comments

@davidhedlund
Copy link

davidhedlund commented May 17, 2017

Nothing at all happens when I open Dashclock, and then click on Settings for Forecastie. This should at least open Forecastie.

@robinpaulson
Copy link
Contributor

In all the other dashclock widgets which I have, there are settings to adjust. In the case of Forecastie, there aren't any settings for the widget. That said, the "Settings" menu item should do something, but I'm not sure opening Forecastie is the right thing.

@robinpaulson
Copy link
Contributor

Perhaps it should open the settings for Forecastie?

@davidhedlund
Copy link
Author

@robinpaulson Yes.

@robinpaulson
Copy link
Contributor

@davidhedlund Are you interested in coding this?

@robinpaulson
Copy link
Contributor

I guess we use the same logic as we do for the home screen widget - clicking calls the Settings Activity.

@davidhedlund
Copy link
Author

@robinpaulson No.

@robinpaulson
Copy link
Contributor

It appears #240 fixes this

@robinpaulson robinpaulson added this to the v1.6 milestone Sep 3, 2017
@davidhedlund
Copy link
Author

@robinpaulson Thanks.

@SpiritCroc
Copy link
Contributor

@robinpaulson it fixes click action on the widget on homescreen, but it doesn't add a settings action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants