Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for astro-bot 2.0 #224

Open
1 task
martrapp opened this issue Nov 24, 2024 · 0 comments · May be fixed by #232
Open
1 task

Preparing for astro-bot 2.0 #224

martrapp opened this issue Nov 24, 2024 · 0 comments · May be fixed by #232
Labels
question Further information is requested

Comments

@martrapp
Copy link
Owner

Describe the Request

I'm having some thoughts about changing the way The Bag integrates when installed as an integration.
And as we talk about breaking changes, you might also have some things that had been pain points for you as a user or contributor but couldn't be changed without breaking compatibility?

Throw it all in! Now is the time to discuss what breaking changes we might be willing to apply to a new major version of The Bag.

Here are my first 2ct:

Now that astro-vtbot integrates @vtbag/inspection-chamber as a devToolbar app, I'm planning to remove the Linter and the LoadingIndicator from the list of things that are installed automatically. Browser support and their error messages have become a lot better than in the old days which makes the Linter a bit more optional. And even though you can deactivate it, forcing the LoadingIndicator on sites now doesn't seem so polite as I thought before ;-). Thus the proposal is to only integrate the devToolbar when astro-vtbot is installed using astro add and have the users explicitely add the Linter and the LoadingIndicator to their global Layout on demand.

Participation

  • I am willing to contribute a PR to make this happen.
@martrapp martrapp added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Nov 24, 2024
@martrapp martrapp linked a pull request Dec 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant