Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_fixes missing_deps discovery respects visibility #105

Open
martis42 opened this issue Mar 16, 2023 · 1 comment
Open

apply_fixes missing_deps discovery respects visibility #105

martis42 opened this issue Mar 16, 2023 · 1 comment

Comments

@martis42
Copy link
Owner

Followup to #18

Currently the feature to automatically add missing direct dependencies does not consider if a discovered dependency is visible to the target under inspection.

Assuming we make no error in matching include statement to target, there are 2 cases we can resolve by implementing this:

  • If multiple targets in the dependency tree provide a given header we skip this right now with a warning. With visibility we could potentially decide which target to choose.
  • Even if we find only a single dependency, it might be invalid. If aliases are involved we might add a target which breaks the build, although the added dependency provides the required header.
@martis42
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant