expand $left/$right in edit-args, replace all $variable matches #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
reviewed
Feb 6, 2023
There was a problem hiding this comment.
Thanks Yuya, this is nice! I have three kinds of comments:
-- Some changes I'd like to see in the documentation. If you don't feel like doing them here, feel free to leave them for me to do in another PR.
-- I would rather not change all the default configs to explicitly include $left $right, unless you feel strongly about that.
-- Some minor take-it-or-leave-it thoughts about the code.
ilyagr
approved these changes
Feb 7, 2023
The default edit_args will be changed to ["$left", "$right"] to support variable substitution without breaking the existing configuration too much. The default merge_args could also be set if we could come up with something meaningful.
…strings The assumption here is temp_dir wouldn't contain invalid utf-8 bytes. If it can contain invalid bytes, maybe we can remove temp_dir from arguments, and chdir(temp_dir) instead. This unblocks the use of Regex. We could use regex::bytes, but it's way more complex as we would have to go back and forth between str/OsStr and bytes.
I'll add string interpolation support to edit-args.
And set edit_args = ["$left", "$right"] by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md