-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move all code out of __init__.py and into a separate module #130
Comments
@zevaverbach Makes sense. A separate module plus the imports put in a |
zevaverbach
added a commit
to zevaverbach/imbox
that referenced
this issue
Jul 26, 2018
…nto __init__.py and put it in __all__. fixes martinrusev#130.
zevaverbach
added a commit
to zevaverbach/imbox
that referenced
this issue
Jul 26, 2018
…Fixes martinrusev#124. Added Pycharm directory to .gitignore. Fixed var names in documentation of query keywords moved Messages and Imbox to their own modules, imported Imbox.imbox into __init__.py and put it in __all__. fixes martinrusev#130. clarified in documentation and Imbox.messages logging that, unless a folder is specified in the kwargs to Imbox.messages, the returned messages will be from the inbox. In the documentation this is accomplished exclusively by the var names. fixes martinrusev#128. amended `8df7d7c` to reflect manual changes made to `README.rst` in current master, but also added `inbox_` to several var names to make that explicit in the documentation. Added flags to messages returned by `fetch_email_by_uid`, using the new function `parse_flags` in `parser.py`. Fixes martinrusev#126. added TODO back into query.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To follow "the principle of least surprise," as most
__init__.py
s are empty or only have imports or__all__
, and thus that's the expectation. Would you accept a PR implementing this?The text was updated successfully, but these errors were encountered: