From b21adc47875f3df32d29695276eec80156fe5ede Mon Sep 17 00:00:00 2001 From: martincostello Date: Sun, 11 Aug 2024 12:14:57 +0100 Subject: [PATCH] Move benchmark artifacts Output the artifacts to the root of the repository. --- .github/workflows/benchmark-ci.yml | 4 ++-- benchmark.ps1 | 5 ++++- tests/API.Benchmarks/Program.cs | 8 +++----- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/benchmark-ci.yml b/.github/workflows/benchmark-ci.yml index fcce9c2ea..384515dd4 100644 --- a/.github/workflows/benchmark-ci.yml +++ b/.github/workflows/benchmark-ci.yml @@ -57,14 +57,14 @@ jobs: gh-repository: 'github.com/${{ github.repository_owner }}/benchmarks' github-token: ${{ secrets.BENCHMARKS_TOKEN }} name: API Benchmarks - output-file-path: tests/API.Benchmarks/BenchmarkDotNet.Artifacts/results/MartinCostello.Api.Benchmarks.ApiBenchmarks-report-full-compressed.json + output-file-path: BenchmarkDotNet.Artifacts/results/MartinCostello.Api.Benchmarks.ApiBenchmarks-report-full-compressed.json tool: 'benchmarkdotnet' - name: Output summary shell: pwsh run: | $repoName = ${env:GITHUB_REPOSITORY}.Split("/")[-1] - $summary = Get-Content -Path (Join-Path ${env:GITHUB_WORKSPACE} "tests" "API.Benchmarks" "BenchmarkDotNet.Artifacts" "results" "MartinCostello.Api.Benchmarks.ApiBenchmarks-report-github.md") -Raw + $summary = Get-Content -Path (Join-Path ${env:GITHUB_WORKSPACE} "BenchmarkDotNet.Artifacts" "results" "MartinCostello.Api.Benchmarks.ApiBenchmarks-report-github.md") -Raw $summary += "`n`n" $summary += "View benchmark results history [here](https://benchmarks.martincostello.com/${repoName})." $summary >> ${env:GITHUB_STEP_SUMMARY} diff --git a/benchmark.ps1 b/benchmark.ps1 index 9cfb1cd68..e8e54f76a 100755 --- a/benchmark.ps1 +++ b/benchmark.ps1 @@ -65,7 +65,10 @@ $benchmarks = (Join-Path $solutionPath "tests" "API.Benchmarks" "API.Benchmarks. Write-Host "Running benchmarks..." -ForegroundColor Green -$additionalArgs = @() +$additionalArgs = @( + "--artifacts", + (Join-Path $solutionPath "BenchmarkDotNet.Artifacts") +) if (-Not [string]::IsNullOrEmpty($Filter)) { $additionalArgs += "--filter" diff --git a/tests/API.Benchmarks/Program.cs b/tests/API.Benchmarks/Program.cs index cd6341ba7..a38e7b13b 100644 --- a/tests/API.Benchmarks/Program.cs +++ b/tests/API.Benchmarks/Program.cs @@ -4,15 +4,13 @@ using BenchmarkDotNet.Running; using MartinCostello.Api.Benchmarks; -args ??= []; - -if (args.Length == 1 && string.Equals(args[0], "--test", StringComparison.OrdinalIgnoreCase)) +if (args.SequenceEqual(["--test"])) { await using var benchmark = new ApiBenchmarks(); await benchmark.StartServer(); - await benchmark.Hash(); - await benchmark.Time(); + _ = await benchmark.Hash(); + _ = await benchmark.Time(); await benchmark.StopServer(); }