Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support "discovery" #22

Closed
jejer opened this issue Jan 18, 2017 · 2 comments
Closed

feature request: support "discovery" #22

jejer opened this issue Jan 18, 2017 · 2 comments

Comments

@jejer
Copy link

jejer commented Jan 18, 2017

Currently ports in ipAddress/discovery/ports not supported

{
  "id": "nginx-mesos",
  "container": {
    "type": "MESOS",
    "docker": {
      "image": "nginx:1.10.2-alpine"
    }
  },
  "cpus": 0.5,
  "mem": 64.0,
  "ipAddress": {
    "networkName": "calico-network",
    "labels": {
      "app": "nginx",
      "group": "production"
    },
    "discovery": {
      "ports": [
        { "number": 80, "name": "http", "protocol": "tcp" }
      ]
    }
  }
}

And portDefinitions is not available in ip-per-container mode.

@jejer
Copy link
Author

jejer commented Jan 20, 2017

I made a fork to make it work.
But no plan to merge back because Unified containerizer/Marathon is working on portMappings.
I think after it's done, we should use port mappings to declare service expose.

@jejer jejer closed this as completed Jan 20, 2017
@martensson
Copy link
Owner

Thanks @jejer for mentioning it, and its true that its been a bit confusing how Marathon has been dealing with ports/services. I will take a new look into it I think! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants