Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arc should not be passed across domain boundaries #36

Open
tjhu opened this issue Oct 10, 2020 · 0 comments
Open

Arc should not be passed across domain boundaries #36

tjhu opened this issue Oct 10, 2020 · 0 comments

Comments

@tjhu
Copy link
Contributor

tjhu commented Oct 10, 2020

We needed a clone method for Create but somehow it got implemented by wrapping Arcs around Creates. Arcs are not RRefable so they should not cross domain boundaries. Instead, the Arc should be placed side of Create

redleaf/domains/usr/proxy/src/gen.rs

Line 93 in 94c06d4

fn as_create_pci(&self) -> Arc<dyn create::CreatePCI> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tjhu