Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add slice function #113

Merged
merged 3 commits into from
Dec 24, 2021
Merged

feat: add slice function #113

merged 3 commits into from
Dec 24, 2021

Conversation

ppeeou
Copy link
Member

@ppeeou ppeeou commented Dec 23, 2021

Fixes #73

@ppeeou ppeeou requested a review from a team December 23, 2021 08:49
vhostv
vhostv approved these changes Dec 24, 2021
View reviewed changes
Copy link

@vhostv vhostv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shine1594
shine1594 approved these changes Dec 24, 2021
View reviewed changes
Copy link
Collaborator

@shine1594 shine1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shine1594 shine1594 merged commit 5666081 into main Dec 24, 2021
@shine1594 shine1594 deleted the feature/slice branch December 24, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhostv vhostv vhostv approved these changes

@shine1594 shine1594 shine1594 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add slice function
3 participants
@ppeeou @shine1594 @vhostv