Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggest] test files place to same location. #165

Open
hg-pyun opened this issue Jun 11, 2022 · 1 comment
Open

[Suggest] test files place to same location. #165

hg-pyun opened this issue Jun 11, 2022 · 1 comment
Labels

Comments

@hg-pyun
Copy link
Collaborator

hg-pyun commented Jun 11, 2022

Summary

How about placing the test file and implementation code together? The two codes are separated and there are many files in the folder, so it is inconvenient to see them together.

As-Is

  • src
    • sum.ts
  • test
    • sum.spec.ts

To-Be

  • src
    • sum.ts
    • sum.spec.ts
@ppeeou
Copy link
Member

ppeeou commented Jun 13, 2022

I referenced the lib below and reflected the folder structure
https://github.com/ramda/ramda
https://github.com/ReactiveX/rxjs
https://github.com/axios/axios
https://github.com/socketio/socket.io
...

However, If the test file is not included when deploying, your suggestion also seems to be fine.

{
   "include": ["src/**/*"],
   "exclude": ["node_modules", "**/*.spec.ts"]
}

What do you think? @shine1594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants