Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemeSet.pack's before option breaks @charset and @import at-rules #71

Closed
yhatt opened this issue Sep 18, 2018 · 0 comments
Closed

ThemeSet.pack's before option breaks @charset and @import at-rules #71

yhatt opened this issue Sep 18, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@yhatt
Copy link
Member

yhatt commented Sep 18, 2018

ThemeSet.pack can inject string before and after packed CSS. By setting before option, theme's @charset and @import at-rules would not work because of the specification of CSS.

It means that marp-team/marp-core, is using before option in ThemeSet.pack, cannot import another theme by @import rule. We require roll-up at-rules before parsing @import for theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant