remove unsupported propTypes #8758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem - Server side validation is cumbersome to set up - When using middlewares and as the SaveButton relied on the SaveContext.saving prop, the SaveButton was only disabled for while the main mutation was loading. However, additional work may still be running. ## Solution For `pessismistic` mode only, we now transparently support server side validation. When a server validation occurs, the DataProvider should throw a ServerValidationError that contains an `errors` object matching the form shape. Besides, we now await the mutation in `useCreateController` and `useEditController`. In `pessimistic` mode, that means the `SaveButton` will stay disabled until the mutation is resolved including its middlewares if any. That does not change anything for the other mutation modes.
Co-authored-by: Gildas Garcia <[email protected]>
## Problem There is now easy way to implement cumulative filters (filtering by multiple tags for instance) without reimplementing `<FilterListItem>`. ### Solution Introduce two new props: - isSelected: accept the item value and the current filters and return a boolean - toggleFilter: accept the item value and the current filters and return new filters
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Co-authored-by: Gildas Garcia <[email protected]>
…-customization Allow to customize how `<FilterListItem>` applies filters
Add server side validation support
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
Introduce withRefreshAuth
Improve AppBar Customization
…rray-input Modifiable size prop for SelectArrayInput
slax57
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Yes you are correct, thanks for the PR!
However:
- since we have released RA v4.9.0, would you mind rebasing your branch on top of the latest version of the
nextbranch please? - Could you also remove
hasShow,hasEditandhasListfromexamples/simple/src/tags/TagEdit.tsxplease?
Thanks
|
Gentle reminder, would you mind rebasing your PR? |
|
Superseded by #9101 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these props weren't included in the interface and setting them resulted in a: