Fix useInput resetting NumberInput when value = 0 #6375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was making every NumberInput go to its defaultValue or initialValue when you change it to zero. You can see the effect here: http://g.recordit.co/l6tTZFrzAg.gif I don't know if there are more side-effects not considered, but this fixes the said issue.
|
Great, thank you! I guess you saw my comment from earlier. It's so easy to miss those, so I wanted to send a quick PR. |
|
Already fixed in #6374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was making every NumberInput change its value to its defaultValue or initialValue when it reaches zero.
If you try to do this:
<NumberInput source="test" min={-10} max={10} defaultValue={6} />It will go back to 6 when it reaches 0, like this
I don't know if there are more side-effects not considered, but this fixes the said issue.