[RFR] Export and document TabbedShowLayoutTabs #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas2595
changed the title
djhi
approved these changes
Feb 25, 2019
djhi
reviewed
Feb 25, 2019
docs/Show.md
Outdated
| const ScrollableTabbedShowLayout = props => ( | ||
| <Show{...props}> | ||
| <TabbedShowLayout tabs={<TabbedShowLayoutTabs scrollable={true}/>}> | ||
| <Tab label="Tab Component 1"> |
There was a problem hiding this comment.
As the TabbedShowLayout usage is already detailed in the previous section, maybe we can even remove all <Tab> here
Removing them as they've already been mentioned previously.
djhi
approved these changes
Feb 25, 2019
|
Thanks! |
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to export and document the component created in #2740.