Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EditButton in Datagrids using rowClick #2686

Merged
merged 1 commit into from
Dec 26, 2018

Conversation

plattdl
Copy link
Contributor

@plattdl plattdl commented Dec 20, 2018

Fixes a similar issue to #2457 where clicking on an Edit Button inside of a Datagrid with rowClick set to "show" doesn't handle the button event properly.

@fzaninotto fzaninotto merged commit 079f792 into marmelab:master Dec 26, 2018
@fzaninotto
Copy link
Member

Good catch! I see the ShowButton still has the same issue, would you mind opening another PR for that one?

@fzaninotto fzaninotto added this to the 2.5.3 milestone Dec 26, 2018
@plattdl
Copy link
Contributor Author

plattdl commented Jan 2, 2019

@fzaninotto Done! Apologies for the delay. Was away for the holidays. Happy to help otherwise!

@fzaninotto
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants