Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to override SnackBar style in Notification Component #2405

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Allow to override SnackBar style in Notification Component #2405

merged 2 commits into from
Oct 26, 2018

Conversation

rameshsyn
Copy link
Contributor

Fix #2400

@rameshsyn rameshsyn mentioned this pull request Oct 9, 2018
Closed
@fzaninotto
Copy link
Member

I've rebased the next branch on master (it was lagging behind the latest minor). Could you please rebase your PR on the new next?

@rameshsyn
Copy link
Contributor Author

@fzaninotto 👍

@fzaninotto
Copy link
Member

fzaninotto commented Oct 26, 2018 •
edited by djhi
Loading

There is something wrong with your rebase, it includes commits that are already in the next branch.

@rameshsyn
Copy link
Contributor Author

@fzaninotto Yeah, my rebase was on the wrong branch. Now, I pulled new next branch changes and add Notification component changes on it and force push.

@fzaninotto fzaninotto added this to the 2.5.0 milestone Oct 26, 2018
@fzaninotto fzaninotto merged commit 7167385 into marmelab:next Oct 26, 2018
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rameshsyn @fzaninotto