[RFR] Automatically add id attribute on input if not specified and accessibility fixes #2351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id
fromsource
prop and set theid
andhtmlFor
props automaticallyaria-label
to buttonsThis allows material-ui to bind labels to their inputs using the
for
attribute, simplifying e2e tests with libraries such asreact-test-utils
and providing better accessibility.For example, using
cypress-testing-library
incypress
, with an input written as:We can now write tests like:
Before, for the same result, we would have written the input as:
NOTE: it is still possible to override the default
id
inferred from thesource
prop