Weird 8px <body> margin when following new vite tutorial
#8407
Labels
Comments
|
I think you are right. We have to fix the docs. To fix that, add the following to your project's <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Vite + React + TS</title>
+ <style>
+ body {
+ margin: 0;
+ }
+ </style>
</head>
</head>
<body>
<div id="root"></div>
<script type="module" src="/src/main.tsx"></script>
</body>
</html> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What you were expecting:
I expect there are no extra margin when following the tutorial
What happened instead:
There are some margins after completing steps of https://marmelab.com/react-admin/Tutorial.html#mapping-api-endpoints-with-resources
Steps to reproduce:
Create new vite project and follow tutorial till https://marmelab.com/react-admin/Tutorial.html#mapping-api-endpoints-with-resources
Related code:
https://github.com/vitejs/vite/blob/main/packages/create-vite/template-react-ts/src/index.css#L28
Other information:
react-admin/docs/Tutorial.md
Line 83 in 202274e
We shall preserve part of this index.css file
Environment
The text was updated successfully, but these errors were encountered: