AutocompleteInput create text is undefined when using a function as option text

[Guy-Adler]

What you were expecting:

When passing the create property to AutocompleteInput, the default text for the creation option should be ra.action.create_item.

What happened instead:

The text was undefined.

Steps to reproduce:

1. Create an AutocompleteInput where the optionText prop is a function.
2. Start typing a text which isn't an option.

Related code:

Code sandbox: https://codesandbox.io/s/fervent-breeze-muqxj4?file=/src/posts/TagReferenceInput.tsx

The change was made on lines 48:

optionText={(choice) => choice.name[locale]}

Other information:

This is probably caused by line 84 of

react-admin/packages/ra-ui-materialui/src/input/useSupportCreateSuggestion.tsx

Lines 69 to 77 in 58f9841

	return {
	id: createValue,
	name:
	filter && createItemLabel
	? translate(createItemLabel, {
	item: filter,
	_: createItemLabel,
	})
	: translate(createLabel, { _: createLabel }),

when passing optionText as a function, the string is always saved under name, which makes it impossible to use a combination of fields as the option text.

Environment

• React-admin version: 4.2.0
• Last version that did not exhibit the issue (if applicable):
• React version: 17
• Browser: Google Chrome 102.0.5005.115
• Stack trace (in case of a JS error):

[Guy-Adler]

As a workaround, one can use

const buildOption = (choice: any) => {
  if (choice.name !== undefined) {
    return choice.name;
  }
  return whatever you want;
};

however, this is very confusing

[antoinefricker]

Bug reproduced, thanks for your report 👍