<Edit mutationMode="pessimistic"> produces "undoable" delete action in toolbar

[despatates]

What you were expecting:
With <Edit mutationMode="pessimistic" />, clicking on the delete button should open a confirmation dialog like it does with undoable={false}.

What happened instead:
With <Edit mutationMode="pessimistic" />, clicking on the delete button deletes the resource like it does with mutationMode="undoable".
A notification is shown with an "undo" action.

Steps to reproduce:
Create an edit form on a resource, and set pessimistic mutation mode.
In the toolbar at the bottom, click on the delete button.

record-2021-02-03_13.32.31.mp4

Related code:

import * as React from 'react';
import { DeleteButton, Edit, SaveButton, SimpleForm, TextInput, Toolbar } from 'react-admin';

const UserEdit = props => (
  <Edit {...props} mutationMode="pessimistic">
    <SimpleForm redirect="show">
      <TextInput source="name" />
      <TextInput source="email" />
    </SimpleForm>
  </Edit>
);

The result is the same with a custom toolbar, following the documentation example:

import * as React from 'react';
import { DeleteButton, Edit, SaveButton, SimpleForm, TextInput, Toolbar } from 'react-admin';

const CustomToolbar = props => (
  <Toolbar {...props}>
    <SaveButton />
    <DeleteButton mutationMode="pessimistic" />
  </Toolbar>
);

const UserEdit = props => (
  <Edit {...props} mutationMode="pessimistic">
    <SimpleForm redirect="show" toolbar={<CustomToolbar />}>
      <TextInput source="name" />
      <TextInput source="email" />
    </SimpleForm>
  </Edit>
);

Environment

• React-admin version: 3.12.0
• React version: 16.14.0
• Browser: Chrome 88.0.4324.96

[djhi]

Thanks for the report. Indeed, the DeleteButton has its undoable prop set to true by default

[djhi]

Sorry I misread. So we actually don't propagate mutationMode accross all actions in a view. This would be a feature request. Howver there is also an issue with the DeleteButton which has undoable prop set to true by default. This prevent users to set another mutationMode. This is an issue. I'll fix this issue asap and add a feature request tag here

[nckenn]

@despatates not related to the issue, just want to ask are you using RA Enterprise Edition?

[despatates]

@nckenn No, I'm not. Why?

[djhi]

Closed automatically by Github but should be kept open for the feature request

[fzaninotto]

The description mentions a bug that you've fixed. What's the feature request?

[djhi]

The propagation of the mutationMode accross all actions in a view as their default mutation mode

[fzaninotto]

As seen on the phone with @djhi, we agree that the bug is now fixed, so I'm closing this issue.

[nckenn]

@despatates can you share your AppBar?

[despatates]

@nckenn My AppBar is very simple, it's a merge between react-admin and Material-UI components.

https://gist.github.com/despatates/3e92ea856ee2db4ddb870e3a0bfa9c3b
If you have any questions please comment on the gist.