Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayInput with array of strings throws "Cannot set a numeric property on an object" #4823

Closed
NikitaVlaznev opened this issue May 17, 2020 · 3 comments · Fixed by #4819
Closed

ArrayInput with array of strings throws "Cannot set a numeric property on an object" #4823

NikitaVlaznev opened this issue May 17, 2020 · 3 comments · Fixed by #4819

Comments

@NikitaVlaznev
Copy link
Contributor

NikitaVlaznev commented May 17, 2020 •
edited
Loading

I have started to get a

Cannot set a numeric property on an object

exception on my forms with ArrayInputs for fields that contains an array of strings.

Bug have appeared in version 3.5.2 after PR #4810.

This happens because this is not a correct way to detect an object values that are used as a subdictionary:

if (value && Object.keys(value).length > 0)

It failes on strings and may be with something else, because:

Object.keys("cats")
[ '0', '1', '2', '3' ]
@NikitaVlaznev NikitaVlaznev mentioned this issue May 17, 2020
Merged
@alanpoulain
Copy link
Contributor

PR to fix this issue: #4819.

@fzaninotto
Copy link
Member

Fixed by #4819

@fzaninotto fzaninotto linked a pull request May 18, 2020 that will close this issue
Fix useInitializeFormWithRecord with an array of objects #4819
Merged
@fzaninotto fzaninotto mentioned this issue May 19, 2020
Closed
@amilosmanli
Copy link
Contributor

Getting the same issue with <ReferenceArrayInput> and <AutocompleArrayInput>

@amilosmanli amilosmanli mentioned this issue May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix useInitializeFormWithRecord with an array of objects alanpoulain/react-admin
4 participants
@fzaninotto @amilosmanli @NikitaVlaznev @alanpoulain