AutocompleteArrayInput: duplicate suggestions

[LoicMahieu]

What you were expecting:

Don't have any duplicate suggestions in the AutocompleteArrayInput.

What happened instead:

Using the ReferenceArrayInput:

<ReferenceArrayInput
  source="relatedPosts"
  label="Related posts"
  reference="posts"
>
  <AutocompleteArrayInput optionText="title" fullWidth />
</ReferenceArrayInput>

When editing a record that already have some relatedPosts, when you delete some of them, it produces duplicated suggestions. See the video:

Steps to reproduce:

• Go to sandbox https://codesandbox.io/s/simple-p40b6 or view https://p40b6.csb.app/#/posts
• Edit a record, add some "related posts" and then save the record
• Go back to edit and remove some related posts.
• You'll see duplicated suggestions and some React warnings with Encountered two children with the same key

Related code:

• CodeSandbox: https://codesandbox.io/s/simple-p40b6

Other information:

Environment

• React-admin version: 3.0.0-beta
• Last version that did not exhibit the issue (if applicable):
• React version: 16.9
• Browser: Chrome
• Stack trace (in case of a JS error):

[LoicMahieu]

It seems to be related to the idsToFetch that are set in the useReferenceArrayInputController.ts#L54-L61.

I tried to remove the newIdsToFetch.length > 0 and it seems to work well but I know if it's a good change:

diff --git a/packages/ra-core/src/controller/input/useReferenceArrayInputController.ts b/packages/ra-core/src/controller/input/useReferenceArrayInputController.ts
index 8aa027fa..0d9007ff 100644
--- a/packages/ra-core/src/controller/input/useReferenceArrayInputController.ts
+++ b/packages/ra-core/src/controller/input/useReferenceArrayInputController.ts
@@ -54,9 +54,7 @@ const useReferenceArrayInputController = ({
     useEffect(() => {
         const newIdsToFetch = difference(input.value, inputValue.current);

-        if (newIdsToFetch.length > 0) {
-            setIdsToFetch(newIdsToFetch);
-        }
+          setIdsToFetch(newIdsToFetch);
         inputValue.current = input.value;
     }, [input.value, setIdsToFetch]);

[LoicMahieu]

I also encountered a another issue but I don't think it is related:

Steps:

• From empty value, add 2 items.
• Focus out
• Focus and tap any chars that doesn't match with any item
• See: some of chip doesn't have text.
• Focus out: the text of the chip appear again

[fzaninotto]

Fixed by #3898