Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpha.3] defaultValue no longer working #3627

Closed
natrim opened this issue Aug 30, 2019 · 2 comments
Closed

[alpha.3] defaultValue no longer working #3627

natrim opened this issue Aug 30, 2019 · 2 comments

Comments

@natrim
Copy link
Contributor

natrim commented Aug 30, 2019

Seems like after rewrite to final-form

the defaultValue on SimpleForm and TabbedForm no longer works

and initialValues is not defined as prop, nor mentioned in docs

@djhi
Copy link
Collaborator

djhi commented Aug 30, 2019

Right.. I wonder how we should handle this as final-form does not support defaultValue.

I think we should retrieve both initialValues and defaultValue, then:

  • use only initialValues if both are defined, with a warning about defaultValue being deprecated and that it will be overridden by initialValues
  • pass defaultValue as initialValues to final-form if defaultValue was the only one defined

@fzaninotto
Copy link
Member

Fixed by #3756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants