Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error in Menu example #3496

Closed
MaxAlex666 opened this issue Aug 8, 2019 · 3 comments
Closed

Documentation error in Menu example #3496

MaxAlex666 opened this issue Aug 8, 2019 · 3 comments

Comments

@MaxAlex666
Copy link

The "menu" component does not receive prop "resources":
https://marmelab.com/react-admin/Admin.html#menu

const Menu = ({ resources, onMenuClick, logout }) => (


...

  • React-admin version: 2.9.5
  • React version: 16.8.6
  • Browser: Chrome 75.0.3770.142
@Kmaschta
Copy link
Contributor

Kmaschta commented Aug 8, 2019

Thanks for opening the issue!

You're right, in fact the Menu is connected to the redux store:

resources: getResources(state),

@q3e
Copy link

q3e commented Aug 20, 2019

Hi @MaxAlex666 I thought the Menu should have the resources prop because we are injecting it through redux.

@fzaninotto
Copy link
Member

This was fixed in #3643, six months ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants