[demo] "dense" prop on submenu headers makes root menu items not consistent

[esistgut]

The dense prop used here

react-admin/examples/demo/src/layout/SubMenu.js

Line 38 in 0fa6ee5

<MenuItem dense button onClick={handleToggle}>

produces a "compact" version of the root menu items:

while the root menu items without submenus keep the "non compact" aspect:

This is the same root menu without the dense prop:

I'm not sure if the desired design is "dense everywhere" (parent and child menus) or if the the dense prop should be used only on child menus.

Please note: as you can see this is based on a local prototype using an extracted version of the demo submenu code so there is a chance the demo doesn't show the same behavior. I tried to do the same tests directly on the demo but encountered some difficulties #3436.

[esistgut]

After the restoring of the demo (#3440) I did some additional tests: the problem doesn't show up on the demo because it forces an older version of material-ui (4.0.0-beta.2) on its dependencies. On this version the dense props don't seem to sort any effect. Upgrading to the current version (4.2.1) makes the problem visible.

[djhi]

Can't reproduce it on the latest alpha. Can you please confirm it is fixed or provide a codesandbox showing the issue?

[fzaninotto]

Already fixed in next (#3718)