Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show custom notification after logout in USER_CHECK #2967

Closed
bitshadow opened this issue Mar 6, 2019 · 2 comments
Closed

Show custom notification after logout in USER_CHECK #2967

bitshadow opened this issue Mar 6, 2019 · 2 comments
Labels
enhancement good first issue

Comments

@bitshadow
Copy link

bitshadow commented Mar 6, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
When user check fails user should be allowed to show custom notification. Currently when auth token expires we want to show a user message with custom message. This behaviour works well in case of USER_LOGIN however it is missing in USER_CHECK.

react-admin/packages/ra-core/src/sideEffect/auth.ts

Line 64 in ed361d3

case USER_CHECK: {

Describe the solution you'd like
User should be allowed to set custom notification which will appear after logout.
@sagarbakhtar sagarbakhtar mentioned this issue May 31, 2019
Merged
@m4theushw
Copy link
Contributor

Should not this issue be closed as the PR proposed is already merged?

@Kmaschta
Copy link
Contributor

Kmaschta commented Jul 7, 2019

Totally. Thanks for the ping!

@Kmaschta Kmaschta closed this as completed Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bitshadow @Kmaschta @m4theushw