CloneButton should sanitize its rest props

[djhi]

What you were expecting:
Using a <CloneButton /> inside an <Toolbar /> from an Edit view should not trigger any React warnings

What happened instead:
Lots of warnings about unkown props passed by the <Toolbar />

Steps to reproduce:
Using a <CloneButton /> inside an <Toolbar /> from an Edit view .

Related code:
https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/button/CloneButton.js#L25

Environment

• React-admin version: 2.6.1
• Last version that did not exhibit the issue (if applicable):

[fzaninotto]

I'm not sure we should address this case.

<CloneButton> is designed to be used in an edit view Actions component, not inside a Toolbar. The Toolbar is basically for submitting the form, not for going to another resource. If we support the usage of any button inside Toolbar, then we can't pass specific props that are useful to SaveButton only. Or we need to specifically sanitize the props injected by Toolbar, which seems like encouraging a bad pattern.

But since we don't explicit the purpose of Toolbar, let's address it.

[mnlbox]

@fzaninotto Please add this as a note to docs. I lost 3 hours until find this issue and fix my problem. 😞

<CloneButton> is designed to be used in an edit view Actions component, not inside a Toolbar. The Toolbar is basically for submitting the form, not for going to another resource.

/CC: @djhi

[djhi]

@mnlbox Waiting for your PR 😉

[mnlbox]

I'm a little new in react-admin and I think it's a little soon for me but thanks for your suggestion. 🤔

[djhi]

This is a documentation pull request. The documentation is located here and it seems you already have the text to put in it :)

[mnlbox]

@djhi I done it man: #2904 😉