Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with react-redux 6.0.0 #2665

Closed
martisekpetr opened this issue Dec 14, 2018 · 5 comments
Closed

Not working with react-redux 6.0.0 #2665

martisekpetr opened this issue Dec 14, 2018 · 5 comments

Comments

@martisekpetr
Copy link

What you were expecting:
After upgrade to react-redux 6.0.0 my app using react-admin should be still working.

What happened instead:
Getting Uncaught Error: Could not find "store" in the context of "Connect(Menu)". Either wrap the root component in a <Provider>, or pass a custom React context provider to <Provider> and the corresponding React context consumer to Connect(Menu) in connect options.

Other information:
Seems to be a direct manifestation of an error outlined in "Breaking changes" section of https://github.com/reduxjs/react-redux/releases/tag/v6.0.0
I would guess the problem lies in the use of now deprecated react-router-redux library.

Environment

  • React-admin version: 2.5.2
  • React version: 16.4
@djhi
Copy link
Collaborator

djhi commented Dec 14, 2018

It won't happen any time soon for the same reason we haven't upgraded to the latest MUI. See @fzaninotto answers on this issue: #2399

@djhi djhi closed this as completed Dec 14, 2018
@fzaninotto
Copy link
Member

Also, react-admin has its own requirements in terms of dependency versions. If you upgrade a dependency to a major release despite react-admin capping the version, don't expect it to work.

@NitaAlexandr
Copy link

Hi,

So I am working with react-admin v2.6.0 and ... what is the best/safest version of react-redux to use with it?

Thank you.

@djhi
Copy link
Collaborator

djhi commented Jan 14, 2019

See https://github.com/marmelab/react-admin/blob/master/packages/ra-core/package.json#L56

@NitaAlexandr
Copy link

NitaAlexandr commented Jan 14, 2019

@djhi God bless you and thank you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants