Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated imp module with importlib #158

Closed
hugovk opened this issue Apr 29, 2023 · 2 comments · Fixed by #160
Closed

Replace deprecated imp module with importlib #158

hugovk opened this issue Apr 29, 2023 · 2 comments · Fixed by #160
Labels

Comments

@hugovk
Copy link
Contributor

hugovk commented Apr 29, 2023

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

https://github.com/rabitt/pysox/blob/0a428b88f76c41e93eecbf49bb27b97c7b3f9de7/setup.py#L6

https://github.com/rabitt/pysox/blob/0a428b88f76c41e93eecbf49bb27b97c7b3f9de7/docs/conf.py#L18

@lostanlen
Copy link
Member

lostanlen commented Jan 5, 2024

Hello @hugovk,

With permission from @rabitt I am taking over the maintenance of pysox and prepare a new release (v1.5) on PyPI. I have push access on this repository.

This seems like the most urgent issue since pysox 1.4 no longer runs on the latest version of Python (3.12). Can you please prepare a PR removing the use of imp and replacing it by importlib? Thank you

@hugovk
Copy link
Contributor Author

hugovk commented Jan 5, 2024

Yes, please see PR #160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants