Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the salami namespaces #134

Merged
merged 3 commits into from
Feb 11, 2017
Merged

Updates to the salami namespaces #134

merged 3 commits into from
Feb 11, 2017

Conversation

bmcfee
Copy link
Contributor

@bmcfee bmcfee commented Sep 20, 2016 •
edited
Loading

#128 and #133

This change is Reviewable

@bmcfee bmcfee added this to the 0.2.2 milestone Sep 20, 2016
@bmcfee bmcfee self-assigned this Sep 20, 2016
@bmcfee
Copy link
Contributor Author

bmcfee commented Sep 20, 2016

TODO: non-music tag support

@justinsalamon
Copy link
Contributor

TODO: non-music tag support

I'm already using JAMS for non-music tags (via the tag_open namespace). Elaborate?

@bmcfee
Copy link
Contributor Author

bmcfee commented Sep 21, 2016

Elaborate?

cf #128 ; salami is adding a new segment label.

This doesn't affect any of the tag namespaces, only segment_salami_*.

@justinsalamon
Copy link
Contributor

gotcha

@bmcfee
Copy link
Contributor Author

bmcfee commented Feb 11, 2017

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee bmcfee merged commit 33dfb1d into master Feb 11, 2017
@bmcfee bmcfee deleted the salami-updates branch February 11, 2017 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmcfee bmcfee

Labels
bug enhancement
Projects
None yet
Milestone
0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@bmcfee @justinsalamon