Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on CSS tool and convert App.css #286

Open
3 tasks
markpalfreeman opened this issue Feb 9, 2018 · 0 comments
Open
3 tasks

Decide on CSS tool and convert App.css #286

markpalfreeman opened this issue Feb 9, 2018 · 0 comments

Comments

@markpalfreeman
Copy link
Owner

markpalfreeman commented Feb 9, 2018

  • Sass or styled-components?

The syntax of either one will be the same, but there are a couple tradeoffs either way. Sass is a little more familiar and leaves your markup/components alone (more traditional). However, React plays really well with new-fangled CSS-in-JS libraries like styled-components, and it enforces "put your styles with your markup" by design.

We need to make a decision on which way to go, then:

  • implement the tooling (see create-react-app docs)
  • convert App.css to use the new way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant