feat: export our own async version of fireEvent #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The promise returned from fireEvent resolves once any pending updates caused by the event have completed (currently uses
wait()
to accomplish this).BREAKING CHANGE: fireEvent no longer returns a boolean and instead returns a promise.
Motivation and Context
Since DOM updates are async in Marko, all assertions following an event needed to wait for a DOM change themselves.
Now, you can wait for the effect of a
fireEvent
method:Checklist: