From 75186eff08be91af1fc60bea086f318a597251d1 Mon Sep 17 00:00:00 2001 From: Mark McDowell Date: Wed, 2 Oct 2019 22:41:08 +0100 Subject: [PATCH] fix(docs): storybook requires an ordering to properties Title needs to be listed as the first property for storybook to compile --- packages/stories/src/indicators/atr/index.stories.tsx | 2 +- packages/stories/src/indicators/bollingerBand/index.stories.tsx | 2 +- packages/stories/src/indicators/elderRay/index.stories.tsx | 2 +- packages/stories/src/indicators/ema/index.stories.tsx | 2 +- packages/stories/src/indicators/forceIndex/index.stories.tsx | 2 +- packages/stories/src/indicators/macd/index.stories.tsx | 2 +- packages/stories/src/indicators/rsi/index.stories.tsx | 2 +- packages/stories/src/indicators/sar/index.stories.tsx | 2 +- packages/stories/tsconfig.json | 2 +- packages/stories/tslint.yaml | 1 + 10 files changed, 10 insertions(+), 9 deletions(-) diff --git a/packages/stories/src/indicators/atr/index.stories.tsx b/packages/stories/src/indicators/atr/index.stories.tsx index 9ace18661..72f86b1c0 100644 --- a/packages/stories/src/indicators/atr/index.stories.tsx +++ b/packages/stories/src/indicators/atr/index.stories.tsx @@ -3,11 +3,11 @@ import { atr } from "react-financial-charts/lib/indicator"; import ATRIndicator from "./atrIndicator"; export default { + title: "Visualization|Indicator/ATR", component: atr, parameters: { componentSubtitle: "Average True Range (ATR) is an indicator that measures volatility.", }, - title: "Visualization|Indicator/ATR", }; export const basic = () => ; diff --git a/packages/stories/src/indicators/bollingerBand/index.stories.tsx b/packages/stories/src/indicators/bollingerBand/index.stories.tsx index a8b640f3b..8e7f0140a 100644 --- a/packages/stories/src/indicators/bollingerBand/index.stories.tsx +++ b/packages/stories/src/indicators/bollingerBand/index.stories.tsx @@ -3,8 +3,8 @@ import { BollingerSeries } from "react-financial-charts/lib/series"; import BollingerIndicator from "./bollingerIndicator"; export default { - component: BollingerSeries, title: "Visualization|Indicator/Bollinger Band", + component: BollingerSeries, }; export const basic = () => ; diff --git a/packages/stories/src/indicators/elderRay/index.stories.tsx b/packages/stories/src/indicators/elderRay/index.stories.tsx index a8ea8389f..9ab33024a 100644 --- a/packages/stories/src/indicators/elderRay/index.stories.tsx +++ b/packages/stories/src/indicators/elderRay/index.stories.tsx @@ -3,6 +3,7 @@ import { forceIndex } from "react-financial-charts/lib/indicator"; import ElderRayIndicator from "./elderRayIndicator"; export default { + title: "Visualization|Indicator/Elder Ray", component: forceIndex, parameters: { componentSubtitle: `This indicator consists of three separate indicators @@ -10,7 +11,6 @@ export default { exponential moving average (EMA). The three indicator help traders determine the trend direction and isolate spots to enter and exit trades.`, }, - title: "Visualization|Indicator/Elder Ray", }; export const basic = () => ; diff --git a/packages/stories/src/indicators/ema/index.stories.tsx b/packages/stories/src/indicators/ema/index.stories.tsx index d6dabc4dd..560013c8a 100644 --- a/packages/stories/src/indicators/ema/index.stories.tsx +++ b/packages/stories/src/indicators/ema/index.stories.tsx @@ -3,11 +3,11 @@ import { LineSeries } from "react-financial-charts/lib/series"; import EMAIndicator from "./emaIndicator"; export default { + title: "Visualization|Indicator/EMA", component: LineSeries, parameters: { componentSubtitle: "Moving averages smooth the price data to form a trend following indicator.", }, - title: "Visualization|Indicator/EMA", }; export const basic = () => ; diff --git a/packages/stories/src/indicators/forceIndex/index.stories.tsx b/packages/stories/src/indicators/forceIndex/index.stories.tsx index c654b1870..dfe29d4a6 100644 --- a/packages/stories/src/indicators/forceIndex/index.stories.tsx +++ b/packages/stories/src/indicators/forceIndex/index.stories.tsx @@ -3,13 +3,13 @@ import { forceIndex } from "react-financial-charts/lib/indicator"; import ForceIndicator from "./forceIndicator"; export default { + title: "Visualization|Indicator/Force Index", component: forceIndex, parameters: { componentSubtitle: `The Force Index is an indicator that uses price and volume to assess the power behind a move or identify possible turning points.`, }, - title: "Visualization|Indicator/Force Index", }; export const basic = () => ; diff --git a/packages/stories/src/indicators/macd/index.stories.tsx b/packages/stories/src/indicators/macd/index.stories.tsx index de5226001..7627aae90 100644 --- a/packages/stories/src/indicators/macd/index.stories.tsx +++ b/packages/stories/src/indicators/macd/index.stories.tsx @@ -3,11 +3,11 @@ import { MACDSeries } from "react-financial-charts/lib/series"; import MACDIndicator from "./macdIndicator"; export default { + title: "Visualization|Indicator/MACD", component: MACDSeries, parameters: { componentSubtitle: "The MACD turns two trend-following indicators, moving averages, into a momentum oscillator by subtracting the longer moving average from the shorter one.", }, - title: "Visualization|Indicator/MACD", }; export const basic = () => ; diff --git a/packages/stories/src/indicators/rsi/index.stories.tsx b/packages/stories/src/indicators/rsi/index.stories.tsx index 03c1cda85..bead53309 100644 --- a/packages/stories/src/indicators/rsi/index.stories.tsx +++ b/packages/stories/src/indicators/rsi/index.stories.tsx @@ -3,11 +3,11 @@ import { RSISeries } from "react-financial-charts/lib/series"; import RSIIndicator from "./rsiIndicator"; export default { + title: "Visualization|Indicator/RSI", component: RSISeries, parameters: { componentSubtitle: "The Relative Strength Index (RSI) is a momentum oscillator that measures the speed and change of price movements.", }, - title: "Visualization|Indicator/RSI", }; export const basic = () => ; diff --git a/packages/stories/src/indicators/sar/index.stories.tsx b/packages/stories/src/indicators/sar/index.stories.tsx index 2a337c673..3ea820d5f 100644 --- a/packages/stories/src/indicators/sar/index.stories.tsx +++ b/packages/stories/src/indicators/sar/index.stories.tsx @@ -3,6 +3,7 @@ import { SARSeries } from "react-financial-charts/lib/series"; import SARIndicator from "./sarIndicator"; export default { + title: "Visualization|Indicator/SAR", component: SARSeries, parameters: { componentSubtitle: `SAR stands for 'stop and reverse'. @@ -10,7 +11,6 @@ export default { prices as they're falling. In this regard, the indicator stops and reverses when the price trend reverses and breaks above or below the indicator.`, }, - title: "Visualization|Indicator/SAR", }; export const basic = () => ; diff --git a/packages/stories/tsconfig.json b/packages/stories/tsconfig.json index 99e4ebb9c..ffd7f54e3 100644 --- a/packages/stories/tsconfig.json +++ b/packages/stories/tsconfig.json @@ -16,7 +16,7 @@ "moduleResolution": "node", "noImplicitReturns": true, "noImplicitThis": true, - "noImplicitAny": true, + "noImplicitAny": false, "noUnusedLocals": true, "outDir": "lib", "sourceMap": true, diff --git a/packages/stories/tslint.yaml b/packages/stories/tslint.yaml index c5f2a384e..934e4b760 100644 --- a/packages/stories/tslint.yaml +++ b/packages/stories/tslint.yaml @@ -3,3 +3,4 @@ extends: "tslint:recommended" rules: completed-docs: false interface-name: false + object-literal-sort-keys: false