Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read password from environment #80

Closed
Baklap4 opened this issue Jan 10, 2019 · 3 comments
Closed

Read password from environment #80

Baklap4 opened this issue Jan 10, 2019 · 3 comments
Labels
enhancement

Comments

@Baklap4
Copy link

Baklap4 commented Jan 10, 2019

While trying to connect to Elastic cloud we now have to supply a username and password. Since the Uri parameter can be read from the environment using ${environment:SOME_ENV_HOST} i thought why not do the same with password. However this seems not to work because when sending the /_bulk the decoded auth header is the following: some_user:${environment:SOME_ENV_PASS} this obviously does not authenticate correctly with Elastic cloud resulting in an unauthorized...
@markmcdowell
Copy link
Owner

Yes, currently we're only passing in username and password if specified in config. It would make sense to allow environment variables though. Possibly ES_USER, ES_PASSWORD,...

@snakefoot snakefoot mentioned this issue Feb 20, 2019
Merged
@snakefoot
Copy link
Collaborator

Created PR #84

@snakefoot
Copy link
Collaborator

Ver. 6.1.0 has been released: https://www.nuget.org/packages/NLog.Targets.ElasticSearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Baklap4 @markmcdowell @snakefoot