Add telemetetry call via eval + setup test for it #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcassel
suggested changes
Mar 7, 2018
| @@ -21,12 +21,19 @@ | |||
| import static org.junit.Assert.assertTrue; | |||
|
|
|||
| public class DataHubInstallTest extends HubTestBase { | |||
| private static int afterTelemetryInstallCount = 0; | |||
There was a problem hiding this comment.
A bunch of our tests call installHub. What if one of the other test classes runs before this one? Wouldn't it be better to check getTelemtryInstallCount before and after the install and look for the +1?
There was a problem hiding this comment.
There's no +1. It only stores the count until it transmits it, then dumps it, usually within 30 seconds. I'm more concerned the check won't pass if a machine is a bit slow at running the tests - as it'll show null instead of 1.
| eval.xquery(query).eval().close(); | ||
| } | ||
| catch(FailedRequestException e) { | ||
| logger.error("Failed to increment feature metric telementry count: " + query, e); |
There was a problem hiding this comment.
(minor) typo: "telementry" -> "telemetry"
dmcassel
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.