Added DHF4 project with test cases for verifying the deployment #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aebadirad
approved these changes
Dec 6, 2018
srinathgit
reviewed
Dec 6, 2018
| } | ||
| dependencies { | ||
| classpath "com.marklogic:ml-data-hub:4.1.0-rc1" | ||
| } |
There was a problem hiding this comment.
I guess this will have to be changed to 4.1.0 after release
There was a problem hiding this comment.
Yeah I just marked this as WIP - I'm going to update it as I test out new bug fixes.
rjrudin
changed the title
|
@srinathgit @akshaysonvane I verified that this is running fine with 4.1.0-rc2 and all the tests pass. We can still wait on merging it until 4.1.0 is released. |
|
Thanks @rjrudin for verifying that it is running fine with 4.1.0-rc2. |
|
@rjrudin Bring this in, or wait for the changes to the tests you're working on? |
Most of the tests in VerifyDeploymentTest do not pass when using DHF 4.0.3
rjrudin
changed the title
|
@aebadirad @srinathgit @akshaysonvane I updated this to depend on 4.1.0. I retested it locally, all looks fine. Also ran mlReloadModules and then ran the test cases, everything looked good. |
|
Alright. Bringing this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests in VerifyDeploymentTest do not pass when using DHF 4.0.3.
I figure we can add to this too as we identify additional resources that a user is likely to deploy in a DHF app.