Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101 - Handle detection of REST directory #147

Merged

Conversation

maeisabelle
Copy link
Contributor

Detection if modules are synched are now done solely in the factories of entity, flow and rest models using SyncStatusService. Kindly review.

…es/<entityName>/<flowtype>/REST and show if it is synched. Detection if modules are synched are done in the factories of entity, flow and rest models.
@paxtonhare
Copy link
Contributor

I just tested this out.

It looks like the file watcher isn't picking up the changes. If I manually refresh it will tell me that files need synching, but not automatically.

@maeisabelle
Copy link
Contributor Author

This is what I found out on my end. The synch status is working on my end when adding a new REST or flow then deploying it to the server. But deleting it (after it was deployed) won’t. Is that what happened to you? When you also said you made changes, is it changes on the actual file or addition of a xqy / sjs file?

@maeisabelle
Copy link
Contributor Author

I made changes in the watcher to not skip the REST directory and also removed the unnecessary getEntities call on onWatchEvent so the synch status will immediately reflect. The only issue I'm seeing is when we remove a directory/file as it is not tracked. Deploying to the server also doesn't deleted remove directories and files. Let me know if we still need to handle this.

paxtonhare added a commit that referenced this pull request Mar 22, 2016
@paxtonhare paxtonhare merged commit 82cd9e4 into Marklogic-retired:master Mar 22, 2016
brucean52 pushed a commit to brucean52/marklogic-data-hub that referenced this pull request Mar 2, 2020
…ISHAKA/explorer-ui:DHFPROD-3770 to develop

* commit '7bb2e47cdae63e4be62cac0363cbdd25199e358c':
  getting the first list item
  Unit and integration tests for expandable snippet view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants