Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow sublist to be single space in pedantic #1924

Merged
merged 1 commit into from
Feb 3, 2021
Merged

fix: allow sublist to be single space in pedantic #1924

merged 1 commit into from
Feb 3, 2021

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Feb 2, 2021

Marked version: v1.2.8

Markdown flavor: Markdown.pl

Description

Sublists with single space are rendered as sublists in pedantic.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Feb 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/5jvtgk4s7
✅ Preview: https://markedjs-git-fork-uzitech-padantic-list-alignment.markedjs.vercel.app

calculuschild
calculuschild approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@calculuschild calculuschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@UziTech UziTech mentioned this pull request Feb 2, 2021
Closed
@UziTech UziTech merged commit 1e36afd into markedjs:master Feb 3, 2021
@UziTech UziTech deleted the padantic-list-alignment branch February 3, 2021 19:46
github-actions bot pushed a commit that referenced this pull request Feb 3, 2021
@semantic-release-bot
chore(release): 1.2.9 [skip ci]
f2535f1 
## [1.2.9](v1.2.8...v1.2.9) (2021-02-03)

### Bug Fixes

* allow sublist to be single space in pedantic ([#1924](#1924)) ([1e36afd](1e36afd))
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 1.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 11, 2021
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
This was referenced Sep 9, 2024
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calculuschild calculuschild calculuschild approved these changes

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

@joshbruce joshbruce Awaiting requested review from joshbruce

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sublist behavior change: Sublists with single space are not rendered as sublists
3 participants
@UziTech @styfle @calculuschild